Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change display of EnergyProblem variable #413

Merged
merged 4 commits into from
Jan 18, 2024
Merged

Change display of EnergyProblem variable #413

merged 4 commits into from
Jan 18, 2024

Conversation

gnawin
Copy link
Member

@gnawin gnawin commented Jan 17, 2024 •
edited
Loading

Pull request details

Describe the changes made in this pull request

Change the display of EnergyProblem variable, now it shows

  • termination_status
  • solved
  • objective_value

List of related issues or pull requests

Closes #321

Collaboration confirmation

As a contributor I confirm

  • I read and followed the instructions in README.dev.md
  • The documentation is up to date with the changes introduced in this Pull Request (or NA)
  • Tests are passing
  • Lint is passing

@gnawin
Copy link
Member Author

gnawin commented Jan 17, 2024

@abelsiqueira is this the right place where the code should be placed at? I put it directly after the creation of the struct. Maybe it can be placed in run_scenario? And suggestions for some other displayed content?

@gnawin gnawin requested a review from abelsiqueira January 17, 2024 13:01
@datejada datejada requested review from datejada and removed request for abelsiqueira January 17, 2024 13:02
@codecov Codecov
Copy link

codecov bot commented Jan 17, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (463079b) 100.00% compared to head (98e1341) 100.00%.
Report is 5 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff            @@
##              main      #413   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines          405       414    +9     
=========================================
+ Hits           405       414    +9

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

datejada
datejada reviewed Jan 17, 2024
View reviewed changes
Copy link
Member

@datejada datejada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gnawin thanks! please double-check the case when the model is infesible

@gnawin
Copy link
Member Author

gnawin commented Jan 17, 2024

@gnawin thanks! please double-check the case when the model is infesible

The relevant options of the EnergyProblem is now reset at the end of create_model!

@gnawin gnawin requested a review from datejada January 17, 2024 14:30
abelsiqueira
abelsiqueira requested changes Jan 17, 2024
View reviewed changes
Copy link
Member

@abelsiqueira abelsiqueira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I made some small suggestions.

@abelsiqueira abelsiqueira merged commit 464da4b into TulipaEnergy:main Jan 18, 2024
7 checks passed
@gnawin gnawin deleted the 321-display-EnergyProblem branch February 21, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abelsiqueira abelsiqueira abelsiqueira approved these changes

@datejada datejada Awaiting requested review from datejada

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement show for the EnergyProblem type
3 participants
@gnawin @abelsiqueira @datejada